The school moral education must adapt to the need of the social politics,the economics,the culture and the productive power,and develops the students' character.It must follow the rule of how one's character comes into being and develops.This article analyses the malpractice of the traditional moral education pattern and puts forward some ideas on how to enhance the effect of the school moral education.